search

iqm-finland / KQCircuits

KLayout Python library for integrated quantum circuit design.
GNU General Public License v3.0
126 stars 71 forks source link

EdgePort's 'side' is inferred from 'towards' #58

Closed iqmtestd closed 10 months ago

iqmtestd commented 10 months ago

in 'produce_waveguide_to_port()' if it is not already specified by the 'side' argument.

Fix #8

github-actions[bot] commented 10 months ago

Test results

       5 files  ±0         5 suites  ±0   4m 52s :stopwatch: +52s    308 tests ±0     308 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 540 runs  ±0  1 540 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 77cb4d58. ± Comparison against base commit dac62a7f.

iqmtestd commented 10 months ago

I've tested that all the generated simulation files remain identical to those generated from main.

iqmtestd commented 10 months ago

not sure if you missed them or skipped them intentionally

Intentionally :). Explicitly setting side is probably better. It kinda documents what's happening. I've only changed a few calls to illustrate the back-up mechanism implemented here.

[In] hanger_resonator_sim.py the two produce_waveguide_to_port calls below the ones you changed have explicit direction set

Yes. These calls use the default use_internal_ports=True, hence side arguments are ignored. I was not trying to fix every unrelated issue (like removing unnecessary parameters) here.