iqm-finland / KQCircuits

KLayout Python library for integrated quantum circuit design.
GNU General Public License v3.0
142 stars 73 forks source link

Fix parameter name verification error #59

Closed iqmtestd closed 1 year ago

iqmtestd commented 1 year ago

in @add_parameter_from.

This PR fixes a small logic error in checking parameter names. It was allowed to specify a non-existant (mistyped) parameter name to change a default value and leaving the developer wondering why the new default is not used.

github-actions[bot] commented 1 year ago

Test results

       5 files  ±0         5 suites  ±0   3m 29s :stopwatch: +8s    333 tests ±0     332 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0  1 665 runs  ±0  1 660 :heavy_check_mark: ±0  5 :zzz: ±0  0 :x: ±0 

Results for commit 479eeaac. ± Comparison against base commit 89f1d377.

:recycle: This comment has been updated with latest results.