iqm-finland / KQCircuits

KLayout Python library for integrated quantum circuit design.
GNU General Public License v3.0
142 stars 73 forks source link

Reload existing PCells without closing KLayout #62

Closed iqmtestd closed 1 year ago

iqmtestd commented 1 year ago

The "KQCircuits -> Reload libraries" command apart from reloading the libraries also saves and re-creates all PCells in every view using the updated code but retaining all the parameter changes of the user.

Fix #14

github-actions[bot] commented 1 year ago

Test results

       5 files  ±0         5 suites  ±0   3m 34s :stopwatch: +17s    333 tests ±0     332 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0  1 665 runs  ±0  1 660 :heavy_check_mark: ±0  5 :zzz: ±0  0 :x: ±0 

Results for commit 5de2b203. ± Comparison against base commit 50e69e19.

:recycle: This comment has been updated with latest results.

iqmtestd commented 1 year ago

I've converted back to draft because (apart from the trivial pylint error) there is still something wrong with this PR using Ubuntu 22 with the latest KLayout 0.28.12. It does work fine with Debian testing and its included KLayout 0.28.5 :)

iqmtestd commented 1 year ago

I've converted back to draft because (apart from the trivial pylint error) there is still something wrong with this PR using Ubuntu 22 with the latest KLayout 0.28.12. It does work fine with Debian testing and its included KLayout 0.28.5 :)

My mistake, there was no problem at all (only the fixed pylint issue), I just had some local configuration mishap.

iqmtestd commented 1 year ago

Just rebased