search

iqmcorp / iqm-google-tag-manager-template

IQM Template for Google Tag Manager Community Gallery
Apache License 2.0
0 stars 0 forks source link

Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter #1

Open semisight opened 3 months ago

semisight commented 3 months ago

https://github.com/iqmcorp/iqm-google-tag-manager-template/blob/d41549ccd80d8f43528d152af553848c26d6b181/template.tpl#L62

When reviewing your template, we've noticed that it is using user-defined parameters to build a URL. It's best practice to use encodeUri() if part of the URL path or encodeUriComponent() if used as a URL parameter.

dtchanpura commented 3 months ago

Hi @semisight, thanks for pointing it out, we will merge this soon once tested.

Though the input will be in format of UUID so won't make much difference but in future if the input format changes it will be handled.