search

iquercorb / OpenModMan

Open Mod Manager - Open source and generic Mod ("Modifications") manager.
GNU General Public License v3.0
95 stars 5 forks source link

[BUG/Wrong Logic] Open in Explorer do opening file instead of explorer folder #104

Closed lmiol closed 3 months ago

lmiol commented 4 months ago

1 being in local library 2 click right button on mod 3 click Open in Explorer... image

Actual result: File opening in program (Winrar for example) Expected result: OR opening folder where file locates (because name Open in Explorer...) OR name of menu should be named Open file...

explanation: in many apps open in explorer and show in explorer are the same action - Open folder with file

iquercorb commented 3 months ago

That was in purpose, but at this time it was assumed that packages were all standard zip (which can be viewed in explorer), but this is no longer the case. So I will change the logic.

lmiol commented 3 months ago

I mean there should be 2 actions Open file Open location Both is very usefull I mean Open in explorer (but rename into Open file) And Open location Both helpfull

iquercorb commented 3 months ago

This is not that simple, you forgot that Mod might also be raw folders... in this case there si not "file" to open, also, the "explore" and "open" shell commands act differently depending user system configuration...

lmiol commented 3 months ago

This is not that simple, you forgot that Mod might also be raw folders... in this case there si not "file" to open, also, the "explore" and "open" shell commands act differently depending user system configuration...

Okay at least don't remove current action "Open in Explorer" what you did

iquercorb commented 3 months ago

Ok back to previous logic but changed menu logic to display "open in explorer" or "open with default program" depending Mod is a folder or file. I will not add "Open Location" menu item since all mods of a library are located in the same folder, this is nonsens in context, and especially in case of multiple selection.