iquercorb / OpenModMan

Open Mod Manager - Open source and generic Mod ("Modifications") manager.
GNU General Public License v3.0
88 stars 5 forks source link

Bug report: Package upgrade breaks on upgradeReplace. #81

Closed PraetorAugustus closed 4 months ago

PraetorAugustus commented 4 months ago

Steps to reproduce:

  1. Query network repository.
  2. Double click updated file (e.g., v1.1 to v1.2).

The new package downloads just fine, but it fails when it tries to replace the old one.

Screenshot 2024-04-20 144523

The debug log is sparse, but here's mine:

[14:25:43] Manager.openHub: E:\Dropbox\Documents\DCS\OpenModMan\DCS Open Beta\hub.omx [14:25:43] ModHub[DCS World].ModChan[ION's F-14 Mixtapes].open: OK [14:25:43] ModHub[DCS World].ModChan[Personal Mods].open: OK [14:25:43] ModHub[DCS World].ModChan[Stingrays Mods].open: OK [14:25:43] ModHub[DCS World].ModChan[Testing].open: OK [14:25:43] ModHub[DCS World].open: OK [14:25:43] Manager.init: OK [14:45:09] ModHub[DCS World].ModChan[Testing].ModPack[Spitfire_LF_Mk_IX_Kneeboards_v1.0.4].restoreData: done in 0.02s [14:45:09] X ModHub[DCS World].ModChan[Testing].NetPack[Spitfire_LF_Mk_IX_Kneeboards_v1.0.5].upgradeReplace

I can (re)install the upgrade package from the Local Library tab, so it's an annoying bug rather than a showstopper.

Let me know if you need more details or want a beta tester.

EDIT: Also, please let me know if this is an ID10T error, a stupid user trick. I tried a couple of workarounds but still had the error.

iquercorb commented 4 months ago

Can you please give the the repository address/coords so I can test with this specific mod ?

PraetorAugustus commented 4 months ago

Of course! And thanks.

address: http://fightinstingrays.com/mods/ name: test

I had a brainwave this morning and tried it with .ozp archives (I normally use .zip). Sadly, that didn't work either.

Let me know if I can help from my end.

PraetorAugustus commented 4 months ago

I found the problem!

I use a custom directory for the Mod Library. The upgrade breaks if I do.

image

When I uncheck the custom directory and use the default, upgrades work as intended.

Hope it's an easy fix.

iquercorb commented 4 months ago

The repository coords you provided doesn't work on my side...

Can you please try using Custom path that doesn't include Tilde (~) in its name ? I also suspect problem with Read/Write permissions.

PraetorAugustus commented 4 months ago

Our web server was down overnight. Sorry about that. It's back up now, and the repo should be working.

Unfortunately, a normal Custom path fails too.

image

Read/Write permissions on my end are all default Windows 11. The default folder works just fine, and it has the same permissions as the custom one.

Edit: now the default folder isn't working, so I don't know what I've done or how I got it to work the first time.

Edit 2: I think the upgrade worked before because I didn't have the mod installed. Downloaded, yes, but not installed. The upgradeReplace function fails any time it tries to upgrade an installed mod. I'll attach a debug log with several tests.

OMM testing upgradeReplace.txt

v1.1.5 --> v1.1.6 is the replace that worked v1.1.6 --> v1.1.7 is an upgrade that didn't

iquercorb commented 4 months ago

Ok, bug found, fixed in source code, will be fixed in the next release

PraetorAugustus commented 4 months ago

Merci beaucoup!