search

iquercorb / OpenModMan

Open Mod Manager - Open source and generic Mod ("Modifications") manager.
GNU General Public License v3.0
88 stars 5 forks source link

[BUG] Mod-package Editor - Saved mod with Indicative Category Custom causes unsaved changes #89

Closed lmiol closed 2 months ago

lmiol commented 2 months ago

Preconditions: Mod already created in Local Library, mod saved with param Indicative Category Custom: MAP

1 right click on not installed mod on local library 2 click Open Mod-package Editor... Actual Result: Save button is Active like i already did changes. If i try to close edit popup then shows up alert Unsaved changes and button Yes or No could works unproperly Expected Result: Save button is inactive (because i did not changes)

the bug is not reproduced if the Indicative Category is not custom

version of app is 1.2.7

iquercorb commented 2 months ago

I am unable to reproduce this on my side, can you please provide link to a mod that produce this ?

PraetorAugustus commented 2 months ago

I am unable to reproduce this on my side, can you please provide link to a mod that produce this ?

I can confirm this behavior, but I haven't taken the time to test the specific circumstances. I'll start paying attention and hopefully one of us can give you more feedback and maybe how to reproduce it.

lmiol commented 2 months ago

it seems problem of CUSTOM: TEXT + DESCRIPTION enabled + text

https://github.com/sedenion/OpenModMan/assets/264879/9ff4fa25-d1d3-4193-a986-cea15de7eba8

Also i didn't record but if you try to Open in Explorer that mod -- Mod Editor is opening instead of explorer (it seems because the same problem but i should tell, maybe it matters for fix)

PraetorAugustus commented 2 months ago

it seems problem of CUSTOM: TEXT + DESCRIPTION enabled + text

Good catch, @lmiol .

@sedenion That matches my experience. Custom Category + Description = OMM asks to save even after I do a Save As.

It's a low-priority bug, though... annoying but not a game-breaker.

iquercorb commented 2 months ago

I think I found the problem. That is not specific to custom category or description but any changes, since the unsaved states of the several elements (category, desc, picture, etc. ) are not properly reset. This is fixed in source code.