iraf-community / iraf

IRAF - Image Reduction and Analysis Facility
https://iraf-community.github.io
Other
151 stars 51 forks source link

mkiraf did not copy login.cl for a new installation #359

Closed astroJarHead closed 8 months ago

astroJarHead commented 8 months ago

I made a new installation of IRAF 2.17 after an OS upgrade to a virtual machine. I noticed that a login.cl was not created in my ~/.iraf directory within which I ran mkiraf. Has anyone else encountered this problem?

I think this could be fixed by substituting this code immediately before line 118:

# Create local login.cl

in mkiraf.sh in

if [ ! -e login.cl ]; then copy="yes" fi

This honestly seems a little simplistic as all it does is check for the existence of a login.cl file. If it is not present, setting copy to "yes" will bring over a copy of the default version from the distribution. Perhaps that is all that is needed, but I haven't given this a lot of thought to see where this might break.

If this is a problem others have encountered or can verify I can make a pull request.

astroJarHead commented 8 months ago

My mistake, I see a login.cl is not needed with 2.17.