iraikov / picnic

A description language for neuroanatomical structures and geometric connectivity.
GNU General Public License v3.0
0 stars 0 forks source link

release-info has some problems #1

Closed sjamaan closed 8 years ago

sjamaan commented 9 years ago

Hi Ivan,

I noticed that picnic is listed in henrietta-cache's output here:

http://code.call-cc.org/henrietta-cache/latest-err-4

The release-info looks like this:

;; -*- scheme -*-
(repo git "git://github.com/iraikov/picnic.git")
(uri targz "https://github.com/iraikov/picnic/tarball/{egg-release}")
(uri files-list "http://code.call-cc.org/files-list?egg={egg-name};release={egg-release}" old-uri)

(release "1.5")
(release "1.4" old-uri)

I think this is incorrect in two ways: the tags directory in svn doesn't have a 1.4 tag, there's only 1.0, 1.1, 1.2 and 1.3 on call-cc.org. Secondly, the files-list URI should be changed to http://code.call-cc.org/files-list?egg={egg-name};egg-release={egg-release};chicken-release={chicken-release}. The release parameter doesn't exist anymore, it was renamed long ago to egg-release.

The chicken-release parameter is currently optional (it is implicitly set to 4), but it's good practice to start using explicit reference to 4 now that CHICKEN 5 is in development. We won't change the implicit value to 5, but we might start requiring it later to keep things simple.

So, for a full example, I think the release-info file should look like this:

;; -*- scheme -*-
(repo git "git://github.com/iraikov/picnic.git")
(uri targz "https://github.com/iraikov/picnic/tarball/{egg-release}")
(uri files-list "http://code.call-cc.org/files-list?egg={egg-name};egg-release={egg-release};chicken-release={chicken-release}" old-uri)

(release "1.5")
(release "1.4")
(release "1.3" old-uri)
(release "1.2" old-uri)
(release "1.1" old-uri)
(release "1.0" old-uri)
iraikov commented 9 years ago

Thanks for the report, I will fix this soon, and also my other eggs on github.

On Fri, Sep 4, 2015 at 8:11 AM, Peter Bex notifications@github.com wrote:

Hi Ivan,

I noticed that picnic is listed in henrietta-cache's output here:

http://code.call-cc.org/henrietta-cache/latest-err-4

The release-info looks like this:

;; -- scheme -- (repo git "git://github.com/iraikov/picnic.git") (uri targz "https://github.com/iraikov/picnic/tarball/{egg-release}") (uri files-list "http://code.call-cc.org/files-list?egg={egg-name};release={egg-release}" old-uri)

(release "1.5") (release "1.4" old-uri)

I think this is incorrect in two ways: the tags directory in svn doesn't have a 1.4 tag, there's only 1.0, 1.1, 1.2 and 1.3 on call-cc.org. Secondly, the files-list URI should be changed to http://code.call-cc.org/files-list?egg={egg-name};egg-release={egg-release};chicken-release={chicken-release}. The release parameter doesn't exist anymore, it was renamed long ago to egg-release.

The chicken-release parameter is currently optional (it is implicitly set to 4), but it's good practice to start using explicit reference to 4 now that CHICKEN 5 is in development. We won't change the implicit value to 5, but we might start requiring it later to keep things simple.

So, for a full example, I think the release-info file should look like this:

;; -- scheme -- (repo git "git://github.com/iraikov/picnic.git") (uri targz "https://github.com/iraikov/picnic/tarball/{egg-release}") (uri files-list "http://code.call-cc.org/files-list?egg={egg-name};egg-release={egg-release};chicken-release={chicken-release}" old-uri)

(release "1.5") (release "1.4") (release "1.3" old-uri) (release "1.2" old-uri) (release "1.1" old-uri) (release "1.0" old-uri)

— Reply to this email directly or view it on GitHub https://github.com/iraikov/picnic/issues/1.