search

irajsb / UE4_Assimp

Assimp mesh importer for Unreal Engine
MIT License
136 stars 29 forks source link

minor fixes for macOS #26

Closed sfjohnston closed 1 year ago

sfjohnston commented 1 year ago

There were a few negative hex values that macOS prefers to see as ints. Also, there was a small scope-related bug.

irajsb commented 1 year ago

Thank you for improving this library

sfjohnston commented 1 year ago

Hi Iraj,

I have been having a problem with UE4_Assimp. I don't think it's this code in particular, as other people have the same problem with other plugin code. When I open UnrealEditor for my (C++) project, I can add and manipulate the Assimp nodes and they work properly. The next time I load the file, however, the blueprint Assimp nodes are all red. Unfortunately, "Refresh all nodes" doesn't work, because the "red" nodes cause other nodes, like foreach, to have the incorrect type. Online, people say, "recompile everything", which I've done, several times. Have you run into this issue? I'm trying the "5.1" branch today rather than "release" to see if that fixes things. If you've run into this and know of a quick fix, please let me know! Thanks, Scott

On Wed, Dec 28, 2022 at 12:31 PM iraj mohtasham @.***> wrote:

Thank you for improving this library

— Reply to this email directly, view it on GitHub https://github.com/irajsb/UE4_Assimp/pull/26#issuecomment-1366901578, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNVAYR6FMZZJB3QRQIUT63WPSPTNANCNFSM6AAAAAATLQXJ5M . You are receiving this because you authored the thread.Message ID: @.***>

sfjohnston commented 1 year ago

I've switched the plugin loading from "Default" to "PreDefault". I don't know what I'm doing, but I noticed this setting in another plugin. It removed the problem. I'll send a pull request, but this really isn't a thoughtfully chosen change!

S

On Thu, Dec 29, 2022 at 8:21 AM Scott Johnston @.***> wrote:

Hi Iraj,

I have been having a problem with UE4_Assimp. I don't think it's this code in particular, as other people have the same problem with other plugin code. When I open UnrealEditor for my (C++) project, I can add and manipulate the Assimp nodes and they work properly. The next time I load the file, however, the blueprint Assimp nodes are all red. Unfortunately, "Refresh all nodes" doesn't work, because the "red" nodes cause other nodes, like foreach, to have the incorrect type. Online, people say, "recompile everything", which I've done, several times. Have you run into this issue? I'm trying the "5.1" branch today rather than "release" to see if that fixes things. If you've run into this and know of a quick fix, please let me know! Thanks, Scott

On Wed, Dec 28, 2022 at 12:31 PM iraj mohtasham @.***> wrote:

Thank you for improving this library

— Reply to this email directly, view it on GitHub https://github.com/irajsb/UE4_Assimp/pull/26#issuecomment-1366901578, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNVAYR6FMZZJB3QRQIUT63WPSPTNANCNFSM6AAAAAATLQXJ5M . You are receiving this because you authored the thread.Message ID: @.***>