search

iralabdisco / ira_laser_tools

All laser type assemblers and manipulators.
BSD 3-Clause "New" or "Revised" License
198 stars 215 forks source link

ROS2/foxy Support #41

Open RoboticsIntelligence opened 3 years ago

RoboticsIntelligence commented 3 years ago

I'm wondering if anyone interested and/or working on porting ira_laser_tools to ROS2/foxy?

kashifkhalid commented 3 years ago

following

JackFrost67 commented 3 years ago

wip

relffok commented 2 years ago

I started porting it a while ago but it turned out to become a little different from the original method. See forked repo. Due to the lack of time it is still pretty rudimentary and missing quite a lot but the laserscan_multi_merger node is usable in my project. Feel free to check it out/contribute/use for your migration!

JackFrost67 commented 2 years ago

I started porting it a while ago but it turned out to become a little different from the original method. See forked repo. Due to the lack of time it is still pretty rudimentary and missing quite a lot but the laserscan_multi_merger node is usable in my project. Feel free to check it out/contribute/use for your migration!

I’ve started to port everything too, but I’ve to read more about ROS2 stuff. I have literally no time atm, but for sure I will take a look at your implementation. Thank you for the support.

tonaaskarwur commented 2 years ago

I started porting it a while ago but it turned out to become a little different from the original method. See forked repo. Due to the lack of time it is still pretty rudimentary and missing quite a lot but the laserscan_multi_merger node is usable in my project. Feel free to check it out/contribute/use for your migration!

I did my attempt to port this too, but couldn't find a way to parse topics and handle dynamic param in ros2. My workaround was by trying to subscribe to both lidars directly. Check it here. The basic idea is following ira_laser_tools, but also missing many things. Thanks for the effort on porting @relffok, I will check your repo and see what goes from there.

nakai-omer commented 2 years ago

We created a PR to support latest ros2: https://github.com/iralabdisco/ira_laser_tools/pull/47

ryanpennings commented 2 years ago

We used @nakai-omer 's humble PR and also did a foxy branch which is working for us. https://github.com/MSDRobotics/ira_laser_tools/tree/foxy