iranroman / SpatialScaper

Creative Commons Attribution 4.0 International
21 stars 4 forks source link

Remove duration from music FMA generator #26

Closed adrianSRoman closed 8 months ago

adrianSRoman commented 1 year ago

On https://github.com/iranroman/SELD-data-generator/blob/1538a4539a24756813a4e6969fb507542e70a9ba/prepare_fsd50k.py#L93, we keep track of both the path and the duration of the FMA tracks. We no longer need this as we are fixing the duration to always be 10 secs (for now). Here we track the duration removal by simply applying:

self.fma_to_dcase_dict[fold][super_class][dcase_path] = fma_track_path
adrianSRoman commented 1 year ago

I will take care of this one. Just adding for everyone's visibility in case you find this to be an issue.

ChrisIck commented 9 months ago

Has this been addressed? I believe it was part of #17 but wanted to confirm (this is why smaller PRs are better)

ChrisIck commented 8 months ago

Addressed in #17