iranroman / musicinformationretrieval.com

Instructional notebooks on music information retrieval.
http://musicinformationretrieval.com
MIT License
1.23k stars 414 forks source link

Modernise and fix most notebooks #61

Closed gijzelaerr closed 5 months ago

gijzelaerr commented 1 year ago

This PR:

Some notebooks have broken upstream dependencies or are example material, not sure what to do there:

FAILED adtlib.ipynb:: - ModuleNotFoundError: No module named 'ADTLib'
FAILED evaluation_beat.ipynb:: -     https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
FAILED evaluation_chord.ipynb:: - TypeError: evaluate() missing 4 required positional arguments: 'ref_intervals', 'ref_labels', 'est_intervals', and 'est_labels'
FAILED exercise_genre_recognition.ipynb:: - NameError: name 'mfcc_busta' is not defined
iranroman commented 11 months ago

Thank you! this is awesome. I will review soon.

iranroman commented 11 months ago

Hello @gijzelaerr, I've been going through the PR, and in general everything looks very good. Something that is unclear is whether you meant to include all the docker files. We currently do not support docker, so if that is a feature that you want to add, I recommend creating a different PR so that we can discuss. The notebook updates will be welcome otherwise.

smith-kyle commented 9 months ago

I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/iranroman/musicinformationretrieval.com/pull/61

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.