search

iraychen / oauth-dot-net

Automatically exported from code.google.com/p/oauth-dot-net
1 stars 0 forks source link

OAuthRequestToken.Equals(IRequestToken other) => Array.Equals limits class utility #23

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Any kind of comparision of 2 OAuthRequestToken objects
2.
3.

What is the expected output? What do you see instead?
If the Roles property is an empty string array for each object, but the
string array is a different object for each, it should probably still
satisfy the Equals test. Instead, it is doing a reference comparison, so if
you have 2 different OAuthRequestTokens, they will fail equality every
time, regardless of the parameters matching. This isn't seen with the
standard InMemory stores, since the objects of a given comparison are
likely to reference the same object where the match is expected.

What version of the product are you using? On what operating system?
0.7.1.0

Please provide any additional information below.

Original issue reported on code.google.com by Samuel.D...@gmail.com on 1 Mar 2010 at 9:22

GoogleCodeExporter commented 9 years ago 
Implementation of equals now compares the values of the array.  Fixed in trunk.

Original comment by chris.s....@gmail.com on 15 Jun 2010 at 3:03