irazasyed / telegram-bot-sdk

🤖 Telegram Bot API PHP SDK. Lets you build Telegram Bots easily! Supports Laravel out of the box.
https://telegram-bot-sdk.com
BSD 3-Clause "New" or "Revised" License
3.04k stars 671 forks source link

Update TelegramResponse.php #1057

Closed irpcpro closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08 :warning:

Comparison is base (50d5401) 43.84% compared to head (3c55cc2) 43.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1057 +/- ## ============================================= - Coverage 43.84% 43.76% -0.08% - Complexity 608 609 +1 ============================================= Files 129 129 Lines 1804 1805 +1 ============================================= - Hits 791 790 -1 - Misses 1013 1015 +2 ``` | [Impacted Files](https://codecov.io/gh/irazasyed/telegram-bot-sdk/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Irfaq+Syed) | Coverage Δ | | |---|---|---| | [src/TelegramRequest.php](https://codecov.io/gh/irazasyed/telegram-bot-sdk/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Irfaq+Syed#diff-c3JjL1RlbGVncmFtUmVxdWVzdC5waHA=) | `80.95% <100.00%> (ø)` | | | [src/TelegramResponse.php](https://codecov.io/gh/irazasyed/telegram-bot-sdk/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Irfaq+Syed#diff-c3JjL1RlbGVncmFtUmVzcG9uc2UucGhw) | `56.52% <100.00%> (+0.96%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/irazasyed/telegram-bot-sdk/pull/1057/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Irfaq+Syed) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Irfaq+Syed). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Irfaq+Syed)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

irazasyed commented 1 year ago

Can you share more details? Where is this issue happening?

irpcpro commented 1 year ago

i've set proxy on guzzle client, but i don't know why my body response is empty. i get http response 200 but body is empty. i don't know why !? i will call https://api.telegram.org/xxx/getMe separately from my browser, i get my bot details. i don't know what is my problem exactly, i'm wokring on it. but in this issue, when body is empty, this line will throw an error for get index result.