search

irazasyed / telegram-bot-sdk

🤖 Telegram Bot API PHP SDK. Lets you build Telegram Bots easily! Supports Laravel out of the box.
https://telegram-bot-sdk.com
BSD 3-Clause "New" or "Revised" License
3.04k stars 671 forks source link

Support forum topics create/edit/close/reopen/delete #1122

Closed makkmarci13 closed 7 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 41.84%. Comparing base (c72ef58) to head (1775323). Report is 2 commits behind head on 3.x.

Files Patch % Lines
src/Methods/Forum.php 0.00% 11 Missing :warning:
src/Objects/ForumTopic.php 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.x #1122 +/- ## ============================================ - Coverage 42.15% 41.84% -0.31% - Complexity 608 614 +6 ============================================ Files 131 133 +2 Lines 1784 1797 +13 ============================================ Hits 752 752 - Misses 1032 1045 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

makkmarci13 commented 8 months ago

What I need to do to solve this 2 check?

irazasyed commented 8 months ago

Add tests please

makkmarci13 commented 8 months ago

I made some, these are okey?

irazasyed commented 7 months ago

Please fix the tests

makkmarci13 commented 7 months ago

I think i fixed it

irazasyed commented 7 months ago

@makkmarci13 Please run tests in your local env and fix them. Push the final patch!

makkmarci13 commented 7 months ago

image

For me, now runs.

makkmarci13 commented 7 months ago

So now what should I do?

irazasyed commented 7 months ago

Your tests are invalid. Just remove it for now and I'll merge.

irazasyed commented 7 months ago

Thanks

sathia-musso commented 6 months ago

Hi, I'd need this file it looks like it's not on the latest version. can it be included please?