ircanywhere / irc-factory

A rebuilt irc-factory from simple-irc-socket and irc-message. Get support at #ircanywhere on freenode
https://ircanywhere.com
MIT License
60 stars 14 forks source link

api.createClient doesn't return a client? #35

Open myndzi opened 8 years ago

myndzi commented 8 years ago

The aforementioned uncaught exception happened due to calls to client.method from var client = api.createClient(). For a method called createClient to NOT return a client object is extremely counterintuitive; it seems to return a descriptor object with information/data you already know because that's what you passed to createClient. Recommend returning the actual client object, or at least renaming the method.