search

ircdocs / irc-defs

More up-to-date IRC Definition Lists
http://defs.ircdocs.horse/
Creative Commons Zero v1.0 Universal
61 stars 19 forks source link

Document both 344 RPL_WHOISCOUNTRY formats #47

Closed jwheare closed 5 years ago

jwheare commented 5 years ago

Not sure when the Insp format changed for this numeric, but 2.0 servers (e.g. irc.europnet.org) don't include the country code as a param.

The last change made to the numeric was here but it looks like the previous code also sent the country code separately so I'm not sure when that was changed

https://github.com/inspircd/inspircd/commit/14e1d1f844c89e14cac24799c80af47ed6767cf2

/cc @SaberUK

DanielOaks commented 5 years ago

I sorta wanna merge these and just document it as client> <nick> [<country code>] :blah blah blah but yeah probably better to do this and mark the Insp2 one as deprecated.

SadieCat commented 5 years ago

That numeric isn't actually sent by InspIRCd 2.0. Its sent by the geopban module for v2 which is in inspircd-extras. Its probably okay to consider it deprecated though.