search

irceline / aq-mobile-be

App for consulting air quality data in Belgium using the ionic framework for Android and iOS
Apache License 2.0
7 stars 8 forks source link

register for the official notifications by default #249

Closed opeeters closed 3 years ago

opeeters commented 3 years ago

See e02ab64 The default setting for official notifications should be subscribe = true. Please review commit e02ab64. I tested the notification. They do arrive and the subscribe/unsubscribe also seems to work..

We will include the functionality of subscribing to a anonymised personal topic (cf #168) at a later stage.

janschulte commented 3 years ago

I just have a couple of questions about this:

The UI currently contains two types of notification: official and automated. Will automated be the same functionality as #168. Or is this something different? For release 1.7.5 we wopuld then only have the official notifications?

You wrote, that the notifications are already working. Did you encounter any problems or should I jsut provide a review of the code?

opeeters commented 3 years ago

The user has to be asked for consent to receive notification. Default state of false is hence the better option.