irceline / opendataviewer

A light weight viewer for displaying air quality data throughout Belgium, customisable via URL-parameters
Apache License 2.0
3 stars 1 forks source link

refine `region` parameter #3

Closed opeeters closed 4 years ago

opeeters commented 4 years ago

See e.g.: https://www.irceline.be/opendataviewer/index.html?lang=en&pollutant=pm25&resolution=rioifdm&interval=hmean&region=vl&lang=en

There should be a cql_filter should be added to the station layer request e.g.:

cql_filter: "network = 'Flanders'",

Alternatives:

For region=br show all for the time being.

Also the fitBounds should be adjusted to the contours of the region being selected.

stevenvdbosch commented 4 years ago

Fitted bounds to region.

stevenvdbosch commented 4 years ago

@opeeters I fitted bounds for Flanders, Wallonia and Brussels => Did you also wanted this last one?

I also added the station cql_filter. (not in case of Brussels)

=> one thing i saw was when i filtered on 'br', the interpolated layer was gone. Is this normal? I guess there exists no "rioifdm:no2_hmean_br" layer as such (this is a var in the interpolatedWmsOptions , line 179 )

For me this branch can be merged with the master

opeeters commented 4 years ago

@stevenvdbosch rioifdm:no2_hmean_br is indeed still missing. Let's just zoom to region Brussels and use the unfiltered station layer and rioifdm:no2_hmean. But do add a case specific to region=br. We might add a clip later. At the moment this does not yet seem necessary..

opeeters commented 4 years ago

@stevenvdbosch Sorry, I think this already as it should be. I did not see your last commit..

opeeters commented 4 years ago

OK, zoom and station layer are fine, just add the uncliped rioifdm to case br..

stevenvdbosch commented 4 years ago

Ok, done. @opeeters

opeeters commented 4 years ago

Thanks!