Why the priority on BCMath in BigMath instead of GMP?

[meghuizen]

Looking at this page: http://phpseclib.sourceforge.net/math/intro.html I see that GMP gives better performance then BCMath.

Why then does BigMath::createFromServerConfiguration() have this order?

if (extension_loaded('bcmath')) {
    return new \PasswordLib\Core\BigMath\BCMath();
} elseif (extension_loaded('gmp')) {
    return new \PasswordLib\Core\BigMath\GMP();
} else {
    return new \PasswordLib\Core\BigMath\PHPMath();
}

I suggest to turn it around. Or are there reasons for priority on bcmath?

[ircmaxell]

The only reason for the current priority is that the system I was on did not have gmp, so I tested bcmath far more deeply. I have no issue swapping them if it's that big of a difference...

[ghost]

According to performance testing done for phpseclib, it seems like a very good idea to prioritize the gmp extension first.

EDIT: I need to learn how to read.

[ircmaxell]

Implemented in PR#10