search

ircmaxell / password_compat

Compatibility with the password_* functions that ship with PHP 5.5
MIT License
2.15k stars 421 forks source link

E_USER_ERROR vs warning #86

Closed nimasdj closed 9 years ago

nimasdj commented 9 years ago

If it makes sense, I suggest to consider to use E_USER_ERROR for the followings 2 lines instead of warning. https://github.com/ircmaxell/password_compat/blob/master/lib/password.php#L37 https://github.com/ircmaxell/password_compat/blob/master/lib/password.php#L235 I submitted PR #87

ircmaxell commented 9 years ago

That was done deliberately to maintain compatibility with PHP 5.5+