search

ircmaxell / password_compat

Compatibility with the password_* functions that ship with PHP 5.5
MIT License
2.15k stars 421 forks source link

Deprecate manual salt option for password_hash #88

Closed adduc closed 2 years ago

adduc commented 9 years ago

I'm not comfortable with the error suppression in the modified unit tests, but it was recommended in PHPUnit's documentation and I didn't know any other method to ignore the deprecated warning.

odolbeau commented 9 years ago

Why do you want to deprecate the salt options? It doesn't seems to be deprecated: http://php.net/manual/en/function.password-hash.php

ircmaxell commented 9 years ago

The salt option is deprecated in PHP7 and moving forward. See this thread: http://marc.info/?t=142782791400003&r=1&w=2

GrahamCampbell commented 9 years ago

It doesn't seems to be deprecated: http://php.net/manual/en/function.password-hash.php

Those docs aren't updated for php 7 yet.

ircmaxell commented 9 years ago

@GrahamCampbell want to take a stab at updating them?

GrahamCampbell commented 9 years ago

I've not been following the changes, so wouldn't do a complete job.

odolbeau commented 9 years ago

Thanks for the link @ircmaxell! :) As we need to provide a custom salt for a specific need (I'll be glad to discuss this if you want) I would like to know if you planned to merge this PR soon?

ircmaxell commented 9 years ago

@odolbeau can you explain this specific need?