Update parser version to 4.0

ircmaxell / php-cfg

A Control Flow Graph implementation in PHP

MIT License

245 stars 43 forks source link

Update parser version to 4.0 #46

Closed PavelJurasek closed 6 years ago

PavelJurasek commented 6 years ago

How should I handle older php versions? I propose a drop of support of PHP5, not so sure about PHP7.0, though.

nikic commented 6 years ago

Dropping PHP 5 is fine. PHP 7 looks like a matter of bumping dependencies, but I don't really get the error message.

PavelJurasek commented 6 years ago

Composer just tries to install the highest versions of sub-dependencies instead of finding those that wouldn't fail on PHP version so for now the PR contains a commit dropping PHP < 7.1.

PavelJurasek commented 6 years ago

OK, I managed to get it to install proper dependencies by removing composer.lock file. It supports php7.0 and higher now.

nikic commented 6 years ago

Thanks!