ircv3 / ircv3-specifications

IRCv3 specifications | Roadmap: https://git.io/IRCv3-Roadmap | Code of conduct: http://ircv3.net/conduct.html
http://ircv3.net
785 stars 79 forks source link

chathistory: Add MSGREFTYPES ISUPPORT token #510

Closed progval closed 1 year ago

progval commented 2 years ago

It appears that both Soju and Matrix2051 have issues implementing one of the types (resp. msgid and timestamp).

While they could add full support eventually, these would cause higher resource usage, so it will be beneficial to indicate a preference even if both types are supported.

@emersion and I considered adding optional msgids to read-marker but it would add a lot of complexity to clients, without much benefit.

syzop commented 1 year ago

Yeah, sounds reasonable.

emersion commented 1 year ago

soju patch: https://git.sr.ht/~emersion/soju/commit/c0bbcdcc0af94438cbc9c05578ce2bcb48a84a26

progval commented 1 year ago

and in matrix2051: https://github.com/progval/matrix2051/commit/6c4f8d477654718d8ae534f8eef086c13d452901

emersion commented 1 year ago

And a Goguma patch which disables chathistory when MSGREFTYPES is missing timestamp, because it only supports that at the moment: https://git.sr.ht/~emersion/goguma/commit/5466e6ee58154bdada45baf47b34a4c8d50b87a3