Open ItsOnlyBinary opened 4 months ago
Reasoning behind removing the vfy
claim:
Having the verify url within the token would encourage implementations to use the url without verifying its trusted, allowing the spoofing of tokens.
The verify url should be a pre-shared component for trust, just like the key would be pre-shared.
With the url having the advantage of not actually sharing the key, so that the host of the third party service could not actually generated trusted tokens.
Our implementation is updated to match the new pull request.
https://github.com/inspircd/inspircd-contrib/blob/master/4/m_ircv3_extjwt.cpp
As prawnsalad has stepped back from IRC development and I have taken over Kiwi IRC development. I cannot allow this ircv3 specification to be abandoned as Kiwi IRC uses it for quite a few plugins. (jitsi conferencing, file uploads, account avatar uploads)
So I have also forked #341 and updated based on comments from within the previous pull-request.