search

ireade / caniuse-embed

📊 Embed realtime data from caniuse.com
https://caniuse.bitsofco.de
325 stars 21 forks source link

Credit MDN (BCD) in the footer #28

Closed foolip closed 3 years ago

netlify[bot] commented 3 years ago

:construction_worker: Deploy request for caniuse-embed pending review. Visit the deploys page to approve it

:hammer: Explore the source changes: bf2dfae0a61dcd2243d835eb0f7df40c62fea3e7

foolip commented 3 years ago

@ddbeck @Elchi3 I sent this after discovering this great embed tool via https://github.com/mdn/browser-compat-data/pull/10442. I thought that linking to "mozilla.org" for BCD isn't quite right, but between MDN and BCD I went with "MDN" as that's the GitHub org BCD is under, and much more recognizable than BCD. WDYT?

@ireade if there would be a way to make the credit conditional in index.html too that might be better than what I proposed, but I wasn't sure where to start looking for that, or if it's fine to just over-credit.

ireade commented 3 years ago

Thanks @foolip ! This looks great, I agree going with MDN is better. The code in the index.html is overridden by the script to it should be fine. Thank you again!

foolip commented 3 years ago

Thanks @ireade! I didn't really understand the code I was editing, but if index.html is just the static content before scripts run it doesn't matter too much that it credits both.