ireade / caniuse-embed

📊 Embed realtime data from caniuse.com
https://caniuse.bitsofco.de
329 stars 21 forks source link

Infinite height glitch on safari (5x and below) #5

Closed JoshuaSand0val closed 7 years ago

JoshuaSand0val commented 7 years ago

Hey, I really like this plugin, but there's a serious issue with it: on Safari 5 (maybe 6) and below, the height of the iframe glitches out and becomes infinite breaking my page. There's also a scrolling glitch but that's not really an issue that has to be addressed. If you don't have safari 5 on your PC, apple still hosts the link here: http://appldnld.apple.com/Safari5/041-5487.20120509.INU8B/SafariSetup.exe

capture

ireade commented 7 years ago

Hi @JoshuaSand0val . Unfortunately, I can't support as far back as Safari 5. According to caniuse itself, that browser is less than 0.05 percent of global use.

JoshuaSand0val commented 7 years ago

That's too bad, however… I believe you actually accidentally fixed the bug. I checked a few days ago, and it wasn't happening (at least on my webpage).

ireade commented 7 years ago

Ah awesome! I think I know what may have caused the bug then. It was the svg icon I was using that didn't have a set height.