ireceptor-plus / issues

0 stars 0 forks source link

typo in return data for stats API #89

Open schristley opened 2 years ago

schristley commented 2 years ago

On the rearrangement/count end point, I send this request:

{
  "repertoires": [
    {
      "repertoire": {
        "repertoire_id": "2"
      }
    },
    {
      "repertoire": {
        "repertoire_id": "5"
      }
    }
  ],
  "statistics": [
    "rearrangement_count",
    "duplicate_count"
  ]
}

and the result is:

{
  "Info": {
    "title": "iReceptorPlus Statistics API",
    "version": "0.3.0",
    "description": "Statistics API for the iReceptor Plus platform.",
    "contact": null
  },
  "Result": [
    {
      "repertoires": {
        "repertoire_id": "2",
        "sample_processing_id": "226",
        "data_processing_id": "236"
      },
      "statistics": [
        {
          "statistic_name": "rearrangement_count",
          "total": 4182,
          "data": [
            {
              "key": "rearrangement_count",
              "count": 4182
            }
          ]
        },
        {
          "statistic_name": "duplicate_count",
          "total": 4182,
          "data": [
            {
              "key": "duplicate_count",
              "count": 4182
            }
          ]
        }
      ]
    },
    {
      "repertoires": {
        "repertoire_id": "5",
        "sample_processing_id": "392",
        "data_processing_id": "402"
      },
      "statistics": [
        {
          "statistic_name": "rearrangement_count",
          "total": 9409,
          "data": [
            {
              "key": "rearrangement_count",
              "count": 9409
            }
          ]
        },
        {
          "statistic_name": "duplicate_count",
          "total": 9409,
          "data": [
            {
              "key": "duplicate_count",
              "count": 9409
            }
          ]
        }
      ]
    }
  ]
}

I believe the repertoires: under Result should be singular, i.e. repertoire:

bcorrie commented 2 years ago

Thanks have created an internal ticket to look into this...

schristley commented 2 years ago

@bcorrie Will the new version of the turnkey fix this? Any timeline on when it will be available?

bcorrie commented 2 years ago

@schristley yes, it is on our Gateway v4.0 list to resolve, can probably have this resolved soon but need to coordinate across production repositories as this error is in production on not only our repositories but at NICD, UKM, and DKFZ as well.

Nominally, this will be fixed in the v4.0 release of the Gateway/Turnkey in June. Whether NICD, UKM, and DKFZ update their repositories we will have to coordinate with them.

schristley commented 2 years ago

Ok, the stats API is available on the staging server (vdj-staging.tacc.utexas.edu), so this could be pushed into production in June too.