search

ireceptor-plus / specifications

Central repository for all iReceptor+ specifications
0 stars 0 forks source link

Collapse duplicate definitions #8

Closed bcorrie closed 4 years ago

bcorrie commented 4 years ago

Collapses the duplicate definitions for the responses, as all responses for all stats are the same.

Changed some of the field names so they are "statistics" or "statistic_name" rather than "fields", as our stats are not directly tied to fields.

bcorrie commented 4 years ago

I think this:

bzimonja commented 4 years ago

It looks good, Only question I'd have is what we want the 'key' to be in count_statistic_array responses. For any other field it's easy, key is the unique value we count on (e.g. IGHV1-03) but for count, 'key' isn't defined (rearrangement_count is the name of enclosing variable, same as 'v_gene' is for IGHV1-03). I guess it's easiest to just repeat rearrangement_count (or duplicate_count) and live with the redundancy?

bcorrie commented 4 years ago

Yes, that makes sense, we can document that in the API.