irecsys / CARSKit

Java-Based Context-aware Recommendation Library
https://carskit.github.io/
GNU General Public License v3.0
124 stars 53 forks source link

Rated items filter #2

Open basvank opened 8 years ago

basvank commented 8 years ago

Based on the discussion in #1 I'd like to propose this pull request.

The behavior of the filter is defined in the setting items.filter in the config file, which defaults to 'none'.

If items.filter=none, no filtering is done, so the algorithm behaves as before If items.filter=user, all items are filtered from the candidate list which are already rated by the user in each and every context If items.filter=user-context, all items are filtered from the candidate list which are already rated by the user in this particular context

Futhermore, I had to move around some files to get the build process and IntelliJ to work fine, as this did not work out of the box based on the project files. Therefore I created a build.xml file and altered the .gitignore such that the .iml and .idea/ files are not in the repo, so very contributor can use his own preferred IDE. I propose to do the same in the main repo, as 601bb144b50a4706e9cea91265b7ac22fb63eb6d broke everything for me due to the changes in the .idea folder. However, this is of course up to you.

irecsys commented 8 years ago

Thanks for your comments! Yes, I did not notice that when I committ them yesterday, I will take care of them once I got a second to do that. Too busy recently....lol