iree-org / iree-test-suites

Test suites for IREE and related projects
Apache License 2.0
1 stars 3 forks source link

Use Exceptions in onnx importer to avoid importing broken test cases. #9

Closed ScottTodd closed 1 month ago

ScottTodd commented 1 month ago

A few of these cases were allowing errors to slip through as broken test cases. Rather than rely on checking for None or watching the logs, this uses Exceptions as error handling.

As a result of fixing these oversights, some broken test cases are deleted. I'm not sure how update_config_xfails.py will handle the list of tests changing.

Logs from running the import script: https://gist.github.com/ScottTodd/bd327bc7e95485b12a9f9ebdcddf0bc2