iree-org / iree

A retargetable MLIR-based machine learning compiler and runtime toolkit.
http://iree.dev/
Apache License 2.0
2.58k stars 581 forks source link

Why are Windows builds disabling AVX ukernel code paths? #13701

Open bjacob opened 1 year ago

bjacob commented 1 year ago

Seen in Windows CI logs:

https://github.com/openxla/iree/actions/runs/5027770230/jobs/9017669780#step:8:528

-- Performing Test IREE_UK_BUILD_X86_64_AVX2_FMA
-- Performing Test IREE_UK_BUILD_X86_64_AVX2_FMA - Failed
-- Performing Test IREE_UK_BUILD_X86_64_AVX512_BASE
-- Performing Test IREE_UK_BUILD_X86_64_AVX512_BASE - Failed
-- Performing Test IREE_UK_BUILD_X86_64_AVX512_VNNI
-- Performing Test IREE_UK_BUILD_X86_64_AVX512_VNNI - Failed

Why is that? IIRC, @benvanik had tried out ukernels locally and was getting AVX code paths. Did that regress or is that a CI-only issue that we never noticed?

The CMakeLists responsible for this are https://github.com/openxla/iree/blob/7a97d4fe6aaa5e5d4822bdb536739c805211d655/runtime/src/iree/builtins/ukernel/arch/x86_64/CMakeLists.txt#L270-L272

Where https://github.com/openxla/iree/blob/7a97d4fe6aaa5e5d4822bdb536739c805211d655/runtime/src/iree/builtins/ukernel/arch/x86_64/CMakeLists.txt#L222-L228

ScottTodd commented 9 months ago

Weird... maybe the GitHub runners / VMs don't have AVX [consistently]? https://github.com/actions/runner/issues/1069 looks related.