search

iree-org / iree

A retargetable MLIR-based machine learning compiler and runtime toolkit.
http://iree.dev/
Apache License 2.0
2.47k stars 548 forks source link

[GPUDistributionPatterns] Propagate predicate attribute for cmpf op #17664

Closed aviator19941 closed 1 week ago

aviator19941 commented 1 week ago

We aren't propagating the predicate attribute for cmpf if it is there, this fixes the missing predicate attribute for cmpf.

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

qedawkins commented 1 week ago

@Groverkss this is running into the issue I had brought up before with this pattern. By not cloning the operation we end up dropping important attributes like this. I think this needs to become a clone of the op and then any distribution related attrs are removed after the clone.

aviator19941 commented 1 week ago

Instead of setting attributes one-by-one, can we clone the operation instead? @qedawkins I had issues with that before, but not anymore, as @raikonenfnu found a better way around my issues.

yeah I can try to clone the operation instead.