This is a take 2 on https://github.com/iree-org/iree/issues/17553. There, I had suggested renaming round_dims_to to max_padding and making it a scalar, while retaining matmul_narrow_{M,N} overriding it for narrow dimensions and clarifying the whole semantics.
Last week we discussed in-person that it would be even nicer to resolve this the other way around: keep the renaming of round_dims_to to max_padding but keep that an array attribute and instead drop the separate matmul_narrow_{M,N}, folding their semantics into that.
This is a take 2 on https://github.com/iree-org/iree/issues/17553. There, I had suggested renaming
round_dims_to
tomax_padding
and making it a scalar, while retainingmatmul_narrow_{M,N}
overriding it for narrow dimensions and clarifying the whole semantics.Last week we discussed in-person that it would be even nicer to resolve this the other way around: keep the renaming of
round_dims_to
tomax_padding
but keep that an array attribute and instead drop the separatematmul_narrow_{M,N}
, folding their semantics into that.