Closed ScottTodd closed 2 months ago
nice! thanks for looking at this - tests that only run on certain build systems, on certain targets, are persistently disabled, or run only with specific non-standard configuration is a big scaling tax.
More ideas for refactoring: https://github.com/iree-org/iree/issues/4644#issuecomment-1832433233
(deciding between scoped, incremental improvements and hack-and-slash refactorings...)
Closing in favor of smaller PRs.
(This will need a few rounds of CI runs to reflect the latest test statuses and fully sync test suites across backends/configs)
Assorted cleanup across the tests/e2e/ folder:
--iree-rocm-target-chip=${IREE_HIP_TEST_TARGET_CHIP}
(not happy that this is required though)ALL_SRCS
glob for test suites that work across all configurationsiree_check_single_backend_test_suite
to justiree_check_test_suite
test_suite
(could also just remove these, they are a convenience for Bazel users)