search

iree-org / iree

A retargetable MLIR-based machine learning compiler and runtime toolkit.
http://iree.dev/
Apache License 2.0
2.85k stars 620 forks source link

[Codegen] Remove depreciated vector distribution transform codegen path #19233

Closed Groverkss closed 1 day ago

Groverkss commented 1 day ago

Removes iree_vector_ext.layout attribute for VectorExt and other related passes which were required for the vector distribution transform dialect path. This path is now depreciated.

bjacob commented 1 day ago

Nice! Does this mean that this code can now also be removed from this header: https://github.com/iree-org/iree/blob/1654ce6dd4cb36061b453e37892d40da2f493bcf/compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.h#L71-L85

Meaning, that struct OpaqueMmaLayout can move into IREEGPUAttrs.cpp, and the getOpaqueMMALayout function becomes static in IREEGPUAttrs.cpp?

Groverkss commented 1 day ago

Nice! Does this mean that this code can now also be removed from this header:

https://github.com/iree-org/iree/blob/1654ce6dd4cb36061b453e37892d40da2f493bcf/compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.h#L71-L85

Meaning, that struct OpaqueMmaLayout can move into IREEGPUAttrs.cpp, and the getOpaqueMMALayout function becomes static in IREEGPUAttrs.cpp?

Yes! Do you want me to do it in this patch or a seperate patch?

bjacob commented 1 day ago

Yes! Do you want me to do it in this patch or a seperate patch?

Up to you!

Groverkss commented 1 day ago

Yes! Do you want me to do it in this patch or a seperate patch?

Up to you!

I'll do it in a follow up patch then :)