Open ScottTodd opened 3 years ago
iree-tools-tf-snapshot
also requires tensorflow
(or tf-nightly
). Probably a similar story for iree-tools-tflite-snapshot
and iree-tools-xla-snapshot
, but I haven't checked.
I kept the "install packages" prerequisite in the new python bindings docs (tracking issue: https://github.com/google/iree/issues/5456). Would be nice to fix this to keep the docs simple.
I think this has been fixed for a very long time. Closing.
https://google.github.io/iree/bindings/python/#prerequisites still suggests installing
python -m pip install --upgrade pip
python -m pip install numpy absl-py
@ScottTodd Should we give this a priority if still open? P1/2?
This just needs someone to verify that requirements are set up correctly and then prune the docs. P2/P3.
Ho there! This bug hasn't been updated in a long time. Good intentions and all, but we're moving this to the backlog. Feel free to bring it back if you think there's a reasonable chance it'll get worked on in the next 6mo!
Discussed first on Discord here
I'm rewriting our docs and came across https://google.github.io/iree/get-started/getting-started-python#python-setup:
Each package should list its dependencies programmatically so we can drop that explicit
pip install
step in our documentation.https://stackoverflow.com/questions/6947988/when-to-use-pip-requirements-file-versus-install-requires-in-setup-py and https://packaging.python.org/discussions/install-requires-vs-requirements/ suggest using the
install_requires
keyword insetup.py
to list dependencies a project minimally requires to run correctly.We use
absl-py
for flags and logging, mostly in tests but also in some util files. Similar story fornumpy
. Certain imports (I testedfrom iree.tf.support import module_utils
but there may be others) fail without these dependencies installed.absl-py
dep to be test only, or just accept it as required.numpy
dep will probably stick.