search

irfaan008 / simple-skill-icons

Showcase your skills with 2500+ icons on your GitHub or resume
https://irfaan008.github.io/simple-skill-icons/
MIT License
23 stars 2 forks source link

Docs about theme are misleading #1

Open jenkin opened 1 year ago

jenkin commented 1 year ago

From the README.

Some icons have a dark and light themed background. You can specify which theme you want as a url parameter. This is optional. The default theme is dark.

But here are all variants.

No theme

My Skills

Dark theme

My Skills

Light theme

My Skills

So the default is colored icons, without any guarantee they works fine on dark or light backgrounds.

irfaan008 commented 1 year ago

@jenkin You are right. This is true. I will update the doc accordingly. Also I am working on to put a rounded square background on each icon so if someone wants that pattern then that would be possible as well.

jenkin commented 1 year ago

Amazing! I suggest you introduce a new theme framed and let the default (no theme) to the raw icon with original colors.