change from comma-separated list

irfanpule / django-form-surveys

Django form survey is an application Django to easier create form survey and easy integrated for your project.

MIT License

56 stars 19 forks source link

change from comma-separated list #82

Open sandstromviktor opened 7 months ago

sandstromviktor commented 7 months ago

Adding choices as a comma-separated list forces the user to write choices without comma. This can make grammar a bit weird.

Suggestions:

Either (preferred) create a new model called choice, and use a onetomany relationship with question, or
use some other, less-common char to split the string into choices.

The first suggestion would allow choices to have more attributes, like "correct answer" or "score", if you want to do a quiz and so on.

PS. I Really like this app, thanks for taking the time!

irfanpule commented 7 months ago

Thanks for your advice @sandstromviktor

Initially this app was designed to be very simple. My assumption is that the option will not contain commas. Choices usually only consist of 1 - 3 words, not a sentence. But if there is a need like that, currently this app is not suitable. It is open to anyone to improve this app.

sandstromviktor commented 6 months ago

I understand. But there are also lots of short standard answers that contains comma. Like yes, I agree or no, not yet or similar. I will try to find some time to change this and submit a PR.

irfanpule commented 2 months ago

Thank you for your suggestion, I will update.