search

irfu / irfu-matlab

Matlab routines to work with space data, particularly with MMS and Cluster/CAA data. Also some general plasma routines.
59 stars 46 forks source link

ESA Cluster CLI moving from "CAIO" to "TAP" #84

Closed thomas-nilsson-irfu closed 2 years ago

thomas-nilsson-irfu commented 2 years ago

Creating a PR here to keep track of the potentially breaking change of switching the Cluster download functions from using the old CAIO to the new TAP interface.

@JanKarlsson (or someone else) please have a look to see that this PR does not mess something up for the Cluster processing before I merge it to our devel (and include it in our next release of irfu-matlab).

Details are tracked in issue https://github.com/irfu/irfu-matlab/issues/75.

I have tried to verify that the download works using the simple examples:

irf;
tint = irf.tint('2005-01-01T05:00:00.000Z/2005-01-01T05:10:00.000Z');
dataSet = 'C3_CP_FGM_5VPS';
TT = caa_download(tint, 'fileinventory:C3_CP_FGM_5VPS');
TT = caa_download('list');
TT = caa_download('listdesc');
TT = caa_download('2005-01-01T05:00:00.000Z/2005-01-01T05:10:00.000Z', 'inventory');
caa_download('2005-01-01T05:00:00.000Z/2005-01-01T05:10:00.000Z', 'C3_CP_FGM_5VPS');
TT = caa_download(tint, 'list:C3_CP_FGM*');
caa_download(tint, 'C1_CP_EFW_L2_E', 'nowildcard');
caa_download(tint, 'C?_CP_FGM_5VPS');
TT = caa_download(['list:' dataSet]);
TTfileList = caa_download(['fileinventory:' dataSet]);
TT = caa_download(['inventory:' dataSet]);
caa_download(tint, dataSet, 'stream');
caa_download(tint, dataSet, 'schedule');
caa_meta(create);

But I have not been able to trigger one of the call to caa_download() which we use, namely: https://github.com/irfu/irfu-matlab/blob/a29753cfff1d64ed5e836dd03a75105f7de0cdcb/%2Blocal/caa_download.m#L449

This PR should solve #75 when merged.

thomas-nilsson-irfu commented 2 years ago

To those of you who possibly just got an e-mail about this Pull request, feel free to simply disregard it!

The pull request here (https://github.com/irfu/irfu-matlab/pull/84) had gotten so old that the code related to Cluster processing had diverted a bit from the one in our devel branch so I had to re-apply all the changes in the special iss75_Cluster_TAP branch on top of the latest devel branch changes in order for @JanKarlsson to properly test the code and its possible impact on Cluster processing.

But when re-applying the changes here on top of your old commits in the devel branch GitHub simply interprets your commits as part of the pull request here and adds all of you to the conversation...