search

iri-pycpt / pycpt

package joining pycpt stuff
4 stars 1 forks source link

Dry mask implemented incorrectly? #59

Open aaron-kaplan opened 6 months ago

aaron-kaplan commented 6 months ago

In an email 2024-03-17, Simon wrote:

So the drymask setting does not appear to be correct. At line 88 [in cca.py], it is being set as a missing value. Instead, the user should be prompted for a value - any (sub-)seasonal accumulation less than that value would then be masked out. I think python allows drymask to be passed as None or as a real value. If that's the case, then line 88 could be easily modified to: cpt.write(drymask). And similarly for line 87 in pcr.py and 98 in mlr.py.

awrobertson commented 6 months ago

I will try to implement this, as well as a skill mask (will create a new issue for the latter).

awrobertson commented 6 months ago

Added to pcr.py and cca.py: if drymask: cpt.write(5371) cpt.write('Y') cpt.write(drymask_value)

plus book keeping in configuration.py (in cpt-extras) See Issue #63

awrobertson commented 3 months ago

On Jul 1, 2024, at 22:39, Simon J Mason simon@iri.columbia.edu wrote:

... confirmed. If drymask = True, the mask is still being set as -999, so the changes Andy made are not implemented in 2.8.2.