search

iridl / python-maprooms

Dash maprooms and tools
0 stars 3 forks source link

Move read_cptdataset into separate predictions.py function file #174

Open drewmresnick opened 1 year ago

drewmresnick commented 1 year ago

Possibly... or make it an issue. The key here is that is we are going to use the same app for other cpt forecasts (biweekly, seasonal...) so all the functions associated with reading will either have to be more fancy to accommodate different cases, or have counterparts for the different cases, and the config file will tell which case we're in. I am just not sure what shape that will all take as I review this now. So it may make sense to leave to other PR.

_Originally posted by @remicousin in https://github.com/iridl/python-maprooms/pull/156#discussion_r974675445_

remicousin commented 1 year ago

This and issue #173 would probably benefit from trying and apply to seasonal CPT outputs. We need some sample files that hopefully we can find from AICCRA colleagues to play with.

aaron-kaplan commented 1 year ago

We have lots of seasonal CPT forecasts in the FBF project.

remicousin commented 1 year ago

Ah yeah... That's good news! Are they going to be read by ptio.open_cptdataset (I had the impression that this was for somewhat files generated by a somewhat recent pyCPT). We can start with some of those while I request from AICCRA team.

drewmresnick commented 1 year ago

@remicousin is this something I should be working on now, or are we waiting until all the changes are merged for the subs maproom to apply it to seasonal data?

aaron-kaplan commented 1 year ago

Are they going to be read by ptio.open_cptdataset (I had the impression that this was for somewhat files generated by a somewhat recent pyCPT).

I'm not aware that the CPT output format has changed recently.

You can find pointers to the datasets in fbf-update-data.py. The ones with "pnep" (precipitation non-exceedance probabiilty) in the name are NextGen seasonal forecasts. The URLs in this file are Ingrid URLs; from there you can read the catalog entries to find the underlying data files.

remicousin commented 1 year ago

@drewmresnick , is that not resolved?