iridl / python-maprooms

Dash maprooms and tools
0 stars 4 forks source link

Boolean columns only have two values #418

Closed aaron-kaplan closed 7 months ago

aaron-kaplan commented 7 months ago

This addresses Dante's comment https://trello.com/c/Y1Xc6Lxt/47-djibouti-new-bad-years#comment-660eec71af54a1ce48f40e17

I think this was originally set to 3 instead of 2 because a boolean column can be 0.0, 1.0, or NaN. But in fact, the NaNs are removed in line 603, so we can lower it to 2 without changing the behavior.

Tested on Djibouti: http://shortfin01.iri.columbia.edu:9998/fbfmaproom/djibouti

Also tested the boolean bad years in Ethiopia and Niger, no change in behavior (the years marked "Bad" are all highlighted, regardless of the position of the slider).