search

iris-edu / irisws-syngine

Project components for the IRIS Synthetics Engine (irisws-syngine) web service
GNU General Public License v2.0
2 stars 0 forks source link

networkcode argument #4

Closed krischer closed 9 years ago

krischer commented 9 years ago

What is the motivation for offering a stationcode parameter but not a networkcode parameter? I guess you want to make clear that one is downloading synthetics?

In practice station codes are not unique so one also needs to set the network codes. The workflows of some people (and me) I've seen store the synthetics in a separate folder but give full ids which makes it easier to match it with actual data. Thus giving the option to also set the network code makes sense from my point of view.

CTrabant commented 9 years ago

We will expose the networkcode parameter. After consulting with some network operators on how they felt about re-using their code we are more comfortable. This is already in our middle ware, just need support in Instaseis.

krischer commented 9 years ago

Good to hear :-)

Instaseis already supports it.

CTrabant commented 9 years ago

I should have been more complete: this change was to enable both networkcode and locationcode. It does not look like the locationcode change to Instaseis has been merged into the master branch yet: https://github.com/krischer/instaseis/pull/12

krischer commented 9 years ago

I was waiting with the merge if it works for you. That seems to be given so I merged it.

CTrabant commented 9 years ago

Hm, didn't know you were waiting for review. I'm not planning on testing branches in general if that's what you were waiting for. Perhaps after release as we add more features, but now there are simply too many nooks and crannies to be branch-switching.

CTrabant commented 9 years ago

Support for networkcode and locationcode is now supported.

Note that networkcode and stationcode are ignored when network and station are specified. The reason this should never work is wildcards would easily produce same-named synthetics. The documentation has been updated to reflect this.

krischer commented 9 years ago

Hm, didn't know you were waiting for review.

Reviews are of course always nice but I'm not expecting that ;-) A comment if the feature does what you want it to do would be helpful to organize our discussion.

Note that networkcode and stationcode are ignored when network and station are specified. The reason this should never work is wildcards would easily produce same-named synthetics. The documentation has been updated to reflect this.

+1. That's also the behaviour of the instaseis /seismograms route.