bentatham commented 4 years ago

This addresses issue #104 .

These changes make it easier to use stationxml-validator as a library in other code by:

Being able to create CommandLine "settings" directly in Java without parsing a string[] of args.
Instantiate the Application class itself with these settings and extending the class to handle errors differently.
Being able to call run with different parameters, like an explicit OutputStream, rather than just for an output file.

I've tried to maintain coding standards and any existing usage of the class, so there should be little-to-no impact on your continued development (it looks like things might be in a bit of flux eg format is not used in CommandLine, etc).

Testing

All existing tests still pass.
Added new basic testing of using the Application class as a library.

timronan commented 4 years ago

Thanks for submitting PR #105. Currently, @yazan-iris is updating a stationxml-validator dependency, the fdns-stationxml-model, and we cannot review your pull request until this update is complete. The update should be done within the week.

We are very sorry for the delay but need to make sure there are no conflicts between the dependency update and the PR. @yazan-iris or myself will provide further details as soon as possible. Let me know if you have any questions.

bentatham commented 4 years ago

Thanks - that was fast! No promises, but let me know if I can do anything to help.

iris-edu / stationxml-validator

#104 - Make easier to use as library #105

Testing