iris-edu / stationxml-validator

GNU General Public License v3.0
16 stars 8 forks source link

Some SOH channels do not have an azimuth and dip - it should not be required #111

Closed SCEDC closed 4 years ago

SCEDC commented 4 years ago

The validator is flagging these SOH channels because they don't have an azimuth and zip.

GLO - GNSS longitude GLA - GNSS latitude GNS - GNSS number of satellites used

But azimuth and dip are not relevant to these channels.

chad-earthscope commented 4 years ago

Those channels appear not use SEED channel naming, but instead some kind of mnemonic. In SEED and StationXML the L instrument code means "Low Gain Seismometer" and the N means "Accelerometer", which are reasonably expected to have an azimuth and dip. Further the G band code means a sample rate >= 1000 to < 5000 Hertz.

I'll let others consider if there might be alternate ways to treat these in the validator, but note that such channels are easily confused for having other, well known, characteristics than these data.

timronan commented 4 years ago

The plan is to add GLO, GLA, GNS channel codes to the list of SOH channels in validation rule restriction C1. We will also add restrictions C1 and C2 to rule 320. This way rule 320 will never trigger on these specific channel codes or Channel:Type == "HEALTH", "FLAG", "MAINTENANCE".

timronan commented 4 years ago

These channel names are already in restriction C1. So I just need to add the restriction to rule 320.

timronan commented 4 years ago

Rule 320 has been updated to include restrictions C1 and C2.
GLO - GNSS longitude GLA - GNSS latitude GNS - GNSS number of satellites used

Are all covered in restriction C1. The metadata will now pass. Stationxml-validator-1.7.1 is now available. Please close this issue when satisfied.

SCEDC commented 4 years ago

The station in question now passes validation. Thanks for addressing it so quickly. - Ellen