search

iris-edu / stationxml-validator

GNU General Public License v3.0
16 stars 8 forks source link

new rule, sensitivity units and response units should match #117

Open crotwell opened 4 years ago

crotwell commented 4 years ago

Proposed rule: input units in instrumentSensitivity should match stage 1 input units. output units in instrumentSensitivity should match last stage output units.

to keep consistency between overall sensitivity and the response.

timronan commented 4 years ago

I am kind of surprised this rule doesn't already exist and should definitely be included as an error:

407: (InstrumentSensitivity:InputUnits:Name must equal Stage[1]:InputUnits:Name AND InstrumentSensitivity:OutputUnits:Name must equal Stage[last]:OutputUnits:Name) OR (InstrumentPolynomial:InputUnits:Name must equal Stage[1]:InputUnits:Name AND InstrumentPolynomial:OutputUnits:Name must equal Stage[last]:OutputUnits:Name)

Do you think that covers the rule?

crotwell commented 4 years ago

Seems good to me.