search

iris-edu / stationxml-validator

GNU General Public License v3.0
16 stars 8 forks source link

Error 312: Unit Case Sensitivity #45

Closed timronan closed 6 years ago

timronan commented 6 years ago

Error 312 is triggering because SEED traditionally uses upper case characters for assigning unit names, but these uppercase unit names are not valid according to the validator unit rules. We could consider including "volts" (plural) into the validator unit rules list of acceptable units to decrease occurrences of Error 312 and 402. Error 312 should be a warning to encourage future users to assign unit names the character cases outlined by SI standards but allow dataless to sxml conversions into the system. We could also automatically assign unit names with the correct case if a unit name matches a regular expression. We would warn the user that their unit name has been automatically changed. Strings containing all uppercase characters are likely an artifact of the dataless to stationxlm conversion process.

Refer to: https://github.com/iris-edu/StationXML-Validator/issues/42 EX1: https://service.iris.edu/fdsnws/station/1/query?net=PB&sta=B005&cha=RDO&starttime=2018-01-01T01:00:00&level=response&format=xml&includecomments=true&nodata=404

timronan commented 6 years ago

What do we do about: Invalid unit NONE.SPECIFIED

EX: https://service.iris.edu/fdsnws/station/1/query?net=UW&sta=QGNG&loc=01&cha=HNE&starttime=2018-06-01T01:00:00&level=response&format=xml&includecomments=true&nodata=404

This is an error and thew validator is triggering correctly.