search

iris-hep / analysis-grand-challenge

Repository dedicated to AGC preparations & execution
https://agc.readthedocs.io
MIT License
24 stars 39 forks source link

Port histogram re-binning to `main` #166

Closed alexander-held closed 1 year ago

alexander-held commented 1 year ago

Port over #165 (and eventually replace by a cabinetry-native method) to main after #158 is merged.

The lower bin edge shift from 120j -> 110j should not only be done in the histogram saving but also in the notebook visualization.

alexander-held commented 1 year ago

In the context of this update (which will change histograms) it would be useful to also fix the inconsistent use of >= / > for b-tagging cuts as pointed out by @eguiraud: https://github.com/iris-hep/analysis-grand-challenge/blob/ca067898756ff4bda17237e0e657121539cc40ee/analyses/cms-open-data-ttbar/ttbar_analysis_pipeline.py#L254-L255

eguiraud commented 1 year ago

Pointed out by @andriiknu actually :grimacing:

According to the spec it should be > everywhere: https://agc.readthedocs.io/en/latest/versionsdescription.html

alexander-held commented 1 year ago

174 is dedicated to tracking the b-tagging.

alexander-held commented 1 year ago

While doing this (which will trigger the need for new reference histograms), also remove the offsetting by 1e-6 in https://github.com/iris-hep/analysis-grand-challenge/blob/ca067898756ff4bda17237e0e657121539cc40ee/analyses/cms-open-data-ttbar/utils/file_output.py#L8-L9 (this was a workaround to avoid issues due to empty bins for the statistical inference stage).